Some corrections and improvements from testing on my side - #2
Open
dmikushin wants to merge 4 commits into
Open
Conversation
Owner
|
Thanks for the changes. I will take a look later today. |
Owner
|
Turns out I had some code for this in working directory for more than 2 years. Also, after you've downloaded the whole thing once, you can:
For both downloads (tarballs and git), the script only downloads sources for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @vishalbiswas thanks for your great work on hacking into Google's comprehensive build system. I was able to produce valid ARM binaries using your script. However, I get Ninja complaints about missing zlib files, unless I re-enable it in the script config. Also, it should be better not to delete existing repos, and only update them. Finally, I have added some info into the README.